AlphaWallet / AlphaWallet/alpha-wallet-android

Setup Danger to prevent Google Play services being included again

Abierto
#366 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement good first issue
Lenguaje dominante
Java
Estrellas
646
Forks
579
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Quote from @hboon

FYI. We have a Danger file at https://github.com/AlphaWallet/alpha-wallet-ios/blob/master/dangerfile.js that contains code to check for such things for iOS. It's just Javascript with convenient access to the code changes. So we have simple checks like if a string is added to the en localisation, we at least warn that other localisations should be added for other messages.

It can be configured so it's run automatically with Travis for PRs. We haven't done that yet, so I'm just running it as a post-commit hook locally:

#!/bin/sh
yarn run danger local

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.