AlphaWallet / AlphaWallet/alpha-wallet-android

WalletConnect v2: Signing from a different wallet

Ouverte
#3,185 0 commentaires 0 réactions 1 personne assignée Réclamée par @seabornlee Voir sur GitHub
Langage dominant
Java
Étoiles
646
Forks
579
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

With WallectConnect v2, if you sign from a different wallet the signature comes from the currently selected wallet.

Reproduce:

go to the react app: https://react-app.walletconnect.com/

Connect using your "wallet A".

Now change wallets to your (valid) "wallet B".

Click 'personal_sign' and process the transaction, which fails (because the app is expecting a signature from wallet A, but you provide a sig from Wallet B).

I see that the address is marked with a warning, but there should be one of the following things:

1. Refuse to sign and state why (Not a good solution).
2. Don't sign and offer to change user keys (Not good either).
3. Before popping open the Sign Dialog (after user clicks next), pop up a warning which is similar to the one you use in the 'Token Shortcut' addition - the user can continue to sign with the original key, or they can abort signing. Use the proper wallet in the sign dialog (NB ActionSheetSignDialog has its own ViewModel with its own wallet fetch).

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.