AlphaWallet / AlphaWallet/alpha-wallet-android

WalletConnect v2: Signing from a different wallet

Abierto
#3,185 0 comentarios 0 reacciones 1 asignado Reclamado por @seabornlee Ver en GitHub
Lenguaje dominante
Java
Estrellas
646
Forks
579
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

With WallectConnect v2, if you sign from a different wallet the signature comes from the currently selected wallet.

Reproduce:

go to the react app: https://react-app.walletconnect.com/

Connect using your "wallet A".

Now change wallets to your (valid) "wallet B".

Click 'personal_sign' and process the transaction, which fails (because the app is expecting a signature from wallet A, but you provide a sig from Wallet B).

I see that the address is marked with a warning, but there should be one of the following things:

1. Refuse to sign and state why (Not a good solution).
2. Don't sign and offer to change user keys (Not good either).
3. Before popping open the Sign Dialog (after user clicks next), pop up a warning which is similar to the one you use in the 'Token Shortcut' addition - the user can continue to sign with the original key, or they can abort signing. Use the proper wallet in the sign dialog (NB ActionSheetSignDialog has its own ViewModel with its own wallet fetch).

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.