AlphaWallet / AlphaWallet/alpha-wallet-android

should replace the QR code icon with information about the current token

Abierto
#1,600 6 comentarios 0 reacciones 2 asignados Asignado a @ChintanRathod Ver en GitHub
Lenguaje dominante
Java
Estrellas
646
Forks
579
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

if you hit Ether token, you get to see a QR code icon upper-right corner which you can receive Ethereum.

![Screenshot_20200914-233656_AlphaWallet](https://user-images.githubusercontent.com/548435/93092860-51e20f00-f6e3-11ea-92a9-c93b421cc0d6.jpg)

If you hit an ENS token, you get a diamon shaped token in its place, hitting it also get you a QR code.

![Screenshot_20200914-233834_AlphaWallet](https://user-images.githubusercontent.com/548435/93092938-6e7e4700-f6e3-11ea-8d9e-b8bbab7cee15.jpg)

Howver, this QR code is the address of the contract. Sending Ether or ENS to this address will cuase the Ether or ENS being lost.

# Solution

Weiwu's thinking.

1. Move it away from the same location as the QR code so users who learned to find the receiving address there won't chance up on it.

2. My guess is that the diamond icon means which network this token is on (different diamons if you are on a testnet or xdai). If true, clicking it should simply tell the user this fact.

3. Use a separate icon (maybe the "Information Icon") to show the contract information, and make it ample clear that this is a contract. For example, top of my head I have this:

- User sees Information Icon
- User clicks Information Icon and sees a screen that describes the token, like contract address, symbol, other Smart Contract MetaData. Address is in one of the fields
- After address there is a "copy" button and a "QR" button - do 𝑛𝑜𝑡 show the QR code without the user pressing that button.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.