AllenNeuralDynamics / AllenNeuralDynamics/aind-metadata-mapper

Update FIP mapper to use passed patch_cable to fiber connection info

未关闭
#416 1 条评论 0 个 reaction 已指派 1 人 已被 @dougollerenshaw 认领 在 GitHub 查看
主要语言
Python
星标
0
派生
2
平均合并
1 天 7 小时
30 天内合并 PR
1

描述

Currently the FIP mapper makes assumptions about the patch_cord to fiber connection scheme. See the detailed issue description here: https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip/issues/40.

Ultimately, it'd be preferable for this information to be specified in the extracted fiber metadata. After:
* https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip/issues/40
* https://github.com/AllenNeuralDynamics/aind-metadata-extractor/issues/35

are resolved, we should update the FIP mapper to:
* Remove the hard-coded assumptions about the patch_cord to fiber mapping
* Verify that all referenced fibers exist in the procedures for the given subject
* Verify that the number of active patch cords is less than or equal to the number of implanted fibers
* Verify that no duplicate mappings exist (i.e. each patch cord maps to only one fiber)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。