AllenNeuralDynamics / AllenNeuralDynamics/aind-metadata-mapper

Update FIP mapper to use passed patch_cable to fiber connection info

Aperta
#416 1 commento 0 reazioni 1 assegnatario Rivendicata da @dougollerenshaw Vedi su GitHub
Lingua principale
Python
Stelle
0
Fork
2
Merge medio
1g 7h
PR unite (30g)
1

Descrizione

Currently the FIP mapper makes assumptions about the patch_cord to fiber connection scheme. See the detailed issue description here: https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip/issues/40.

Ultimately, it'd be preferable for this information to be specified in the extracted fiber metadata. After:
* https://github.com/AllenNeuralDynamics/Aind.Physiology.Fip/issues/40
* https://github.com/AllenNeuralDynamics/aind-metadata-extractor/issues/35

are resolved, we should update the FIP mapper to:
* Remove the hard-coded assumptions about the patch_cord to fiber mapping
* Verify that all referenced fibers exist in the procedures for the given subject
* Verify that the number of active patch cords is less than or equal to the number of implanted fibers
* Verify that no duplicate mappings exist (i.e. each patch cord maps to only one fiber)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.