AllenNeuralDynamics / AllenNeuralDynamics/aind-metadata-manager

Quality control write_standard_file() will overwrite existing metadata

Ouverte
#33 0 commentaires 0 réactions 1 personne assignée Réclamée par @seanmcculloch Voir sur GitHub
Langage dominant
Python
Étoiles
0
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
At [this line](https://github.com/AllenNeuralDynamics/aind-metadata-manager/blob/11e9f2fa2b0be6bb84cceda6976dcc5b3e19f880/src/aind_metadata_manager/metadata_manager.py#L550) the existing manager code calls `write_standard_file()` for the QC metadata. If a previous quality_control.json file existed, it will be overwritten at this step.

**Expected behavior**
If one exists, a previous quality_control.json file should be loaded, validated as a `QualityControl` object and then merged with the new QC metrics by calling `qc = qc_old + qc_new`. Then `qc.write_standard_file()` on the final merged output.

**Other context**
This was also happening for processing metadata, but I flagged this to Sean in a separate PR and it sounds like he'll fix it there.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.