AllenNeuralDynamics / AllenNeuralDynamics/aind-metadata-manager

Quality control write_standard_file() will overwrite existing metadata

Abierto
#33 0 comentarios 0 reacciones 1 asignado Reclamado por @seanmcculloch Ver en GitHub
Lenguaje dominante
Python
Estrellas
0
Forks
0
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**
At [this line](https://github.com/AllenNeuralDynamics/aind-metadata-manager/blob/11e9f2fa2b0be6bb84cceda6976dcc5b3e19f880/src/aind_metadata_manager/metadata_manager.py#L550) the existing manager code calls `write_standard_file()` for the QC metadata. If a previous quality_control.json file existed, it will be overwritten at this step.

**Expected behavior**
If one exists, a previous quality_control.json file should be loaded, validated as a `QualityControl` object and then merged with the new QC metrics by calling `qc = qc_old + qc_new`. Then `qc.write_standard_file()` on the final merged output.

**Other context**
This was also happening for processing metadata, but I flagged this to Sean in a separate PR and it sounds like he'll fix it there.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.