AllenFang / AllenFang/react-bootstrap-table
onRowSelect and onRowClick should be properties
- Lingua principale
- JavaScript
- Stelle
- 2.2k
- Fork
- 761
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Currently, onRowClick and onRowSelect are set within an object, meaning that the functions set to them have to be global, or defined then and there. Because of this, the state of the component can't be changed, which restricts a lot of react functionality.
If onRowSelect and onRowClick were set as properties themselves, instead of as properties of properties:
``
it would remove the need for a global and allow access to the rest of the component.
The other option would be if selectRow or options could take functions that returned objects then they could be defined like:
```
options: function() {
return { onRowClick: this.rowClick };
}
```
and the same functionality is added.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.