AllenFang / AllenFang/react-bootstrap-table
onRowSelect and onRowClick should be properties
- Dominant language
- JavaScript
- Stars
- 2.2k
- Forks
- 761
- PR merge metrics
- No merged PRs in 30d
Description
Currently, onRowClick and onRowSelect are set within an object, meaning that the functions set to them have to be global, or defined then and there. Because of this, the state of the component can't be changed, which restricts a lot of react functionality.
If onRowSelect and onRowClick were set as properties themselves, instead of as properties of properties:
``
it would remove the need for a global and allow access to the rest of the component.
The other option would be if selectRow or options could take functions that returned objects then they could be defined like:
```
options: function() {
return { onRowClick: this.rowClick };
}
```
and the same functionality is added.
Contributor guide
Assessment
This issue has not been assessed yet.