AllenFang / AllenFang/react-bootstrap-table

Table header and Table body is not align after updating from version 2.5.7 to 4.3.1

Aperta
#2,113 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
2.2k
Fork
761
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hello,

We are using react-bootstrable-table 2.5.7 updating to the latest(4.3.1),

As I dig dipper I look into the library, react-bootstrap-table column width actually computed, and every time the window is resize this will trigger the column width computation

The method is _**_adjustHeaderWidth**_, and there is a condition that preventing to compute the width,
https://github.com/AllenFang/react-bootstrap-table/blob/master/src/BootstrapTable.js#L1476
_**if (isScroll || this.isVerticalScroll !== isScroll) {**_
but 2.5.7 version without this condition the alignment is fine.

The condition actually is isScroll to check if there is a scroll which is always false(As I check in our case).
_**tbody.parentNode.getBoundingClientRect().height**_ and
_**tbody.parentNode.parentNode.getBoundingClientRect().height**_ has the same value

and isVerticalScroll is initialize to false

Please advise.

Thank you!

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.