AllenFang / AllenFang/react-bootstrap-table

Table header and Table body is not align after updating from version 2.5.7 to 4.3.1

Open
#2,113 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
761
PR merge metrics
No merged PRs in 30d

Description

Hello,

We are using react-bootstrable-table 2.5.7 updating to the latest(4.3.1),

As I dig dipper I look into the library, react-bootstrap-table column width actually computed, and every time the window is resize this will trigger the column width computation

The method is _**_adjustHeaderWidth**_, and there is a condition that preventing to compute the width,
https://github.com/AllenFang/react-bootstrap-table/blob/master/src/BootstrapTable.js#L1476
_**if (isScroll || this.isVerticalScroll !== isScroll) {**_
but 2.5.7 version without this condition the alignment is fine.

The condition actually is isScroll to check if there is a scroll which is always false(As I check in our case).
_**tbody.parentNode.getBoundingClientRect().height**_ and
_**tbody.parentNode.parentNode.getBoundingClientRect().height**_ has the same value

and isVerticalScroll is initialize to false

Please advise.

Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.