AllenCell / AllenCell/vole-core

Move the pick buffer out of `PickVolume`

Aperta
#414 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Tech Debt
Lingua principale
TypeScript
Stelle
106
Fork
11
Merge medio
3g 51m
PR unite (30g)
12

Descrizione

## Use Case

Currently, `PickVolume` owns the pick buffer, which means that all pick rendering needs to be handled by it, including for other meshes.

Ideally, `ThreeJsPanel` should own the pick buffer instead.

## Solution

- [ ] Remove the pick buffer from `PickVolume` and move it into `ThreeJsPanel` instead.
- [ ] Pass the pick buffer into the animate functions so `PickVolume` can write to it.
- [ ] Optional (possible second PR): refactor existing mesh shaders so they can write to the pick buffer in the same render pass?

## Alternatives

_Please describe any alternatives you've considered, even if you've dismissed them_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.