AllenCell / AllenCell/vole-core

Move the pick buffer out of `PickVolume`

Abierto
#414 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Tech Debt
Lenguaje dominante
TypeScript
Estrellas
106
Forks
11
Merge medio
3 d 51 min
PR fusionados (30 d)
12

Descripción

## Use Case

Currently, `PickVolume` owns the pick buffer, which means that all pick rendering needs to be handled by it, including for other meshes.

Ideally, `ThreeJsPanel` should own the pick buffer instead.

## Solution

- [ ] Remove the pick buffer from `PickVolume` and move it into `ThreeJsPanel` instead.
- [ ] Pass the pick buffer into the animate functions so `PickVolume` can write to it.
- [ ] Optional (possible second PR): refactor existing mesh shaders so they can write to the pick buffer in the same render pass?

## Alternatives

_Please describe any alternatives you've considered, even if you've dismissed them_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.