AllenCell / AllenCell/vole-core

Move the pick buffer out of `PickVolume`

未關閉
#414 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Tech Debt
主要語言
TypeScript
星號
106
分支
11
平均合併
3 天 51 分鐘
30 天內合併 PR
12

描述

## Use Case

Currently, `PickVolume` owns the pick buffer, which means that all pick rendering needs to be handled by it, including for other meshes.

Ideally, `ThreeJsPanel` should own the pick buffer instead.

## Solution

- [ ] Remove the pick buffer from `PickVolume` and move it into `ThreeJsPanel` instead.
- [ ] Pass the pick buffer into the animate functions so `PickVolume` can write to it.
- [ ] Optional (possible second PR): refactor existing mesh shaders so they can write to the pick buffer in the same render pass?

## Alternatives

_Please describe any alternatives you've considered, even if you've dismissed them_

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。