AllenCell / AllenCell/vole-core

don't multiply canvas size with devicePixelRatio

Aperta
#337 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
106
Fork
11
Merge medio
3g 51m
PR unite (30g)
12

Descrizione

## Use Case

Some users on older hardware experience slowness.
Hypothesizing that rendering fewer canvas pixels can help. This goes on the assumption that visual display resolution would be high enough without needing every native device pixel.

## Solution

Allow an option (advanced settings) to reduce canvas's internal rendering size by devicePixelRatio. This is a threejs webgl configuration setting. See https://github.com/allen-cell-animated/vole-core/blob/ccf761a520b01bb91a61a5edcfcc2cea3549b784/src/ThreeJsPanel.ts#L171
Test performance increase on low end and high end laptops for both macos and pc. Also test visual quality difference. If we feel good about it on all devices, then we can default to the lower res setting and get performance win.

## Alternatives

Bonus: detect low performance (how??) and automatically switch canvas resolution.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.