AllenCell / AllenCell/vole-core

don't multiply canvas size with devicePixelRatio

Open
#337 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
106
Forks
11
Avg merge
3d 51m
Merged PRs (30d)
12

Description

## Use Case

Some users on older hardware experience slowness.
Hypothesizing that rendering fewer canvas pixels can help. This goes on the assumption that visual display resolution would be high enough without needing every native device pixel.

## Solution

Allow an option (advanced settings) to reduce canvas's internal rendering size by devicePixelRatio. This is a threejs webgl configuration setting. See https://github.com/allen-cell-animated/vole-core/blob/ccf761a520b01bb91a61a5edcfcc2cea3549b784/src/ThreeJsPanel.ts#L171
Test performance increase on low end and high end laptops for both macos and pc. Also test visual quality difference. If we feel good about it on all devices, then we can default to the lower res setting and get performance win.

## Alternatives

Bonus: detect low performance (how??) and automatically switch canvas resolution.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.