AllenCell / AllenCell/cell-feature-explorer

remove firebase type from app

未关闭
#139 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Tech debt
主要语言
TypeScript
星标
2
派生
1
PR 合并指标
30 天内没有已合并 PR

描述

## Use Case

All firebase types should be hidden behind the image dataset interface but one has leaked out: the `dateCreated` in state/image-dataset/types.ts is a `Timestamp` which is a firebase type.

## Solution

Change the runtime definition of dateCreated to be a regular Date or number... and update the firebase dataset implementation to convert the value.

## Alternatives

Have firebase return a number instead of a Timestamp?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。