AllenCell / AllenCell/cell-feature-explorer

remove firebase type from app

Open
#139 0 comments 0 reactions 0 assignees View on GitHub
Tech debt
Dominant language
TypeScript
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

## Use Case

All firebase types should be hidden behind the image dataset interface but one has leaked out: the `dateCreated` in state/image-dataset/types.ts is a `Timestamp` which is a firebase type.

## Solution

Change the runtime definition of dateCreated to be a regular Date or number... and update the firebase dataset implementation to convert the value.

## Alternatives

Have firebase return a number instead of a Timestamp?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.