Alir3z4 / Alir3z4/html2text

mark_code with <p class="pre">

未关闭
#189 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
2.2k
派生
296
PR 合并指标
30 天内没有已合并 PR

描述

$ html2text --version
html2text 2016.9.19
$ python --version
Python 2.7.14

I noticed the code doesn't handle marking code when its wrapped around ```

``` tags. I found during parsing it doesn't handle attrs and I was able to get around this by:
```
$ diff -u __init__.py /usr/local/lib/python2.7/dist-packages/html2text/__init__.py
--- __init__.py 2017-10-22 22:23:31.588370064 -0700
+++ /usr/local/lib/python2.7/dist-packages/html2text/__init__.py 2016-09-18 15:03:55.000000000 -0700
@@ -600,7 +600,7 @@
if tag in ["td", "th"] and start:
self.td_count += 1

- if tag == "pre" or ('class' in attrs and attrs['class'] == 'pre') or tag == 'p' and self.pre == 1:
+ if tag == "pre":
if start:
self.startpre = 1
self.pre = 1
```

-----
This works though it seems a bit messy to submit a PR from. Any better ideas?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。