Alir3z4 / Alir3z4/html2text

mark_code with <p class="pre">

Abierto
#189 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
2.2k
Forks
296
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

$ html2text --version
html2text 2016.9.19
$ python --version
Python 2.7.14

I noticed the code doesn't handle marking code when its wrapped around ```

``` tags. I found during parsing it doesn't handle attrs and I was able to get around this by:
```
$ diff -u __init__.py /usr/local/lib/python2.7/dist-packages/html2text/__init__.py
--- __init__.py 2017-10-22 22:23:31.588370064 -0700
+++ /usr/local/lib/python2.7/dist-packages/html2text/__init__.py 2016-09-18 15:03:55.000000000 -0700
@@ -600,7 +600,7 @@
if tag in ["td", "th"] and start:
self.td_count += 1

- if tag == "pre" or ('class' in attrs and attrs['class'] == 'pre') or tag == 'p' and self.pre == 1:
+ if tag == "pre":
if start:
self.startpre = 1
self.pre = 1
```

-----
This works though it seems a bit messy to submit a PR from. Any better ideas?

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.