AlibabaResearch / AlibabaResearch/DAMO-ConvAI

Use of Set Conversion for SQL Query Results Comparison in execute_sql Function

未关闭
#190 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
1.6k
派生
250
PR 合并指标
30 天内没有已合并 PR

描述

Issue Description:

There is an incorrect use of set conversion for SQL query results comparison in the execute_sql function within the evaluation.py file. The current implementation compares the predicted SQL results with the ground truth SQL results using sets, which removes duplicates and disregards the order of the results. This can lead to incorrect evaluation results when duplicates are important or when the order of the results matters.

Expected Behavior:

The function should compare the results of the SQL queries directly without converting them to sets, to preserve duplicates and the order of the results.

Suggested Fix:

Replace the line of code that converts the results to sets with a direct comparison of the lists:

```
if predicted_res == ground_truth_res:
res = 1
```

This ensures that the evaluation considers both duplicates and the order of the results.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。