AlibabaResearch / AlibabaResearch/DAMO-ConvAI

Use of Set Conversion for SQL Query Results Comparison in execute_sql Function

Ouverte
#190 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
1.6k
Forks
250
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Issue Description:

There is an incorrect use of set conversion for SQL query results comparison in the execute_sql function within the evaluation.py file. The current implementation compares the predicted SQL results with the ground truth SQL results using sets, which removes duplicates and disregards the order of the results. This can lead to incorrect evaluation results when duplicates are important or when the order of the results matters.

Expected Behavior:

The function should compare the results of the SQL queries directly without converting them to sets, to preserve duplicates and the order of the results.

Suggested Fix:

Replace the line of code that converts the results to sets with a direct comparison of the lists:

```
if predicted_res == ground_truth_res:
res = 1
```

This ensures that the evaluation considers both duplicates and the order of the results.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.