AlibabaResearch / AlibabaResearch/DAMO-ConvAI

Use of Set Conversion for SQL Query Results Comparison in execute_sql Function

Open
#190 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
1.6k
Forks
250
PR merge metrics
No merged PRs in 30d

Description

Issue Description:

There is an incorrect use of set conversion for SQL query results comparison in the execute_sql function within the evaluation.py file. The current implementation compares the predicted SQL results with the ground truth SQL results using sets, which removes duplicates and disregards the order of the results. This can lead to incorrect evaluation results when duplicates are important or when the order of the results matters.

Expected Behavior:

The function should compare the results of the SQL queries directly without converting them to sets, to preserve duplicates and the order of the results.

Suggested Fix:

Replace the line of code that converts the results to sets with a direct comparison of the lists:

```
if predicted_res == ground_truth_res:
res = 1
```

This ensures that the evaluation considers both duplicates and the order of the results.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.