AlgebraicJulia / AlgebraicJulia/SyntacticModels.jl

AMR.load and AMR.amr_to_string changes data during read in test/amr_examples

Aperta
#25 1 commento 0 reazioni 1 assegnatario Rivendicata da @quffaro Vedi su GitHub
Lingua principale
Julia
Stelle
4
Fork
5
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

amr_to_string appears to change data as its being read. This means that a test case `(AMR.amr_to_string(AMR.load(ASKEModel, model_expr))) == modelrep` will always fail. Here are two concrete observations of this issue:

1. "@" character is omitted on `AMR.load`
**Expected** Call the argument of `amr_to_string` in the test case `M`. A substring of `M.header` should read:
"...ASKE Model Representation: SIR Model@0.1..."
**Observed** The substring of `M.header` omits the "@" character:
"...ASKE Model Representation: SIR Model0.1..."
2. A match case in `amr_to_string` erroneously interprets `ODERecord` as `ODEList`
**Expected** The `ODERecord` is interpreted by the `ODERecord` match case and return "ODE_Record = ..."
**Observed** The relevant substring in the output of `amr_to_string` has "ODE Equations" instead.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.