AlgebraicJulia / AlgebraicJulia/SyntacticModels.jl

AMR.load and AMR.amr_to_string changes data during read in test/amr_examples

Abierto
#25 1 comentario 0 reacciones 1 asignado Reclamado por @quffaro Ver en GitHub
Lenguaje dominante
Julia
Estrellas
4
Forks
5
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

amr_to_string appears to change data as its being read. This means that a test case `(AMR.amr_to_string(AMR.load(ASKEModel, model_expr))) == modelrep` will always fail. Here are two concrete observations of this issue:

1. "@" character is omitted on `AMR.load`
**Expected** Call the argument of `amr_to_string` in the test case `M`. A substring of `M.header` should read:
"...ASKE Model Representation: SIR Model@0.1..."
**Observed** The substring of `M.header` omits the "@" character:
"...ASKE Model Representation: SIR Model0.1..."
2. A match case in `amr_to_string` erroneously interprets `ODERecord` as `ODEList`
**Expected** The `ODERecord` is interpreted by the `ODERecord` match case and return "ODE_Record = ..."
**Observed** The relevant substring in the output of `amr_to_string` has "ODE Equations" instead.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.