AerospaceNU / AerospaceNU/better-engine-control-software

Can we make `ISequence`s const?

Aperta
#25 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
question
Lingua principale
C++
Stelle
5
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

https://github.com/AerospaceNU/better-engine-control-software/blob/main/src/constants/AllSequences.h

We define our sequences as global variables. Ideally I want some const protection on them so they don't get randomly mutated by some function.

However, this requires us to make `ISequence` methods all const.

I want

- [ ] A good argument as for why we should commit to `ISequence` being const. `ISequence` is an interface, all future deriving classes must now act const as well, should we commit to this design idea?
- [ ] Impl the const

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.