AerospaceNU / AerospaceNU/better-engine-control-software

Can we make `ISequence`s const?

Open
#25 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C++
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

https://github.com/AerospaceNU/better-engine-control-software/blob/main/src/constants/AllSequences.h

We define our sequences as global variables. Ideally I want some const protection on them so they don't get randomly mutated by some function.

However, this requires us to make `ISequence` methods all const.

I want

- [ ] A good argument as for why we should commit to `ISequence` being const. `ISequence` is an interface, all future deriving classes must now act const as well, should we commit to this design idea?
- [ ] Impl the const

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.