AerospaceNU / AerospaceNU/better-engine-control-software

Make a global `ICommBoundary` variable for communication

未关闭
#14 0 条评论 0 个 reaction 已指派 2 人 已被 @ritika-gurjar 认领 在 GitHub 查看
enhancement help wanted question
主要语言
C++
星标
5
派生
2
PR 合并指标
30 天内没有已合并 PR

描述

In hindsight, I think it's best to prioritize the convenience of easy telemetry over cleanly modular design.

The core issue is that I think telemetry should be just as easy as printing to `std::cout`, just include and you can write your call. Currently, we have to pass a `ICommBoundary` through constructors, not ideal and requires non trivial refactoring and work.

I was thinking of making a basic interface like `bind_comm_object()` to set the global var, and for now `get_comm_object()` to get it. Later on I want to move to even more ergonomic interfaces for text logging and formatting.

If you want to try this issue, talk to me first. I'm not convinced this is a 100% good idea so I want to hear your opinion.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。