AerospaceNU / AerospaceNU/better-engine-control-software

Make a global `ICommBoundary` variable for communication

Offen
#14 0 Kommentare 0 Reaktionen 2 zugewiesene Personen Beansprucht von @ritika-gurjar Auf GitHub ansehen
enhancement help wanted question
Vorherrschende Sprache
C++
Sterne
5
Forks
2
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

In hindsight, I think it's best to prioritize the convenience of easy telemetry over cleanly modular design.

The core issue is that I think telemetry should be just as easy as printing to `std::cout`, just include and you can write your call. Currently, we have to pass a `ICommBoundary` through constructors, not ideal and requires non trivial refactoring and work.

I was thinking of making a basic interface like `bind_comm_object()` to set the global var, and for now `get_comm_object()` to get it. Later on I want to move to even more ergonomic interfaces for text logging and formatting.

If you want to try this issue, talk to me first. I'm not convinced this is a 100% good idea so I want to hear your opinion.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.