Adventure-Bot / Adventure-Bot/adventure-bot

Normalized items

Open
#9 0 comments 0 reactions 1 assignee Claimed by @brian-gates View on GitHub
Dominant language
TypeScript
Stars
7
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Problem: full copies of items exist everywhere. Reduce the size and redundancy of state by normalizing items within the character slice.

- [x] create `items` slice
- [x] create `itemCreated` action
- [x] dispatch `itemCreated` action whenever an item is added to the game
- [x] dispatch `itemDestroyed` action whenever an is removed from the game
- [ ] reduce `statsModified` in character slice on `itemEquipped` and `itemRemoved` (instead of within the selector)
- [ ] migrate character inventory and equipment to reference `items` slice
- [ ] update selectors to denormalize back to original shape

Success criteria: No `Item`s in the character slice, only ids. No change in behavior.

https://redux.js.org/usage/structuring-reducers/updating-normalized-data

Alternative for consideration: `inventory` slice.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.