AdguardTeam / AdguardTeam/dnsproxy

Change counterintuitive implementation of “Fastest IP address“ in case of non-A/AAAA response types

未关闭
#376 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
feature request
主要语言
Go
星标
3.3k
派生
343
PR 合并指标
30 天内没有已合并 PR

描述

**Current behavior:**
The switch “Fastest IP address“ makes AdGuard query all configured upstreams. Then…

- if the upstreams return an A or AAAA record type, then AdGuard measures the time to open up a TCP connection to ports 80 and 443 of all returned IP addresses of all configured upstreams. AdGuard then return a manipulated DNS record, that only contains the fastest IP address.
- else (i.e. the upstreams return a different record type) AdGuard enters the normal “load-balancing“ mode. (see https://github.com/AdguardTeam/dnsproxy/blob/a87a3dfd6b737144a16ef92d130319d12184f129/proxy/exchange.go#L28 )

**Suggested behavior:**
If the upstreams return a different record type than A or AAAA, then AdGuard enters the normal “Parallel requests“ mode, i.e. change line 28 to “return upstream.ExchangeParallel(ups, req)“ (like in https://github.com/AdguardTeam/dnsproxy/blob/a87a3dfd6b737144a16ef92d130319d12184f129/proxy/exchange.go#L22 ).

**Rationale:**
As a user of “Fastest IP address“ I have to accept that generally all upstreams are queried in order to get the best overall system performance. In the case of A/AAAA records that is the fastest content server (not the fastest DNS answer). In case of other record types, that would be the fastest DNS answer, in my opinion.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。