AdguardTeam / AdguardTeam/dnsproxy

Change counterintuitive implementation of “Fastest IP address“ in case of non-A/AAAA response types

Open
#376 1 comment 0 reactions 0 assignees View on GitHub
feature request
Dominant language
Go
Stars
3.3k
Forks
343
PR merge metrics
No merged PRs in 30d

Description

**Current behavior:**
The switch “Fastest IP address“ makes AdGuard query all configured upstreams. Then…

- if the upstreams return an A or AAAA record type, then AdGuard measures the time to open up a TCP connection to ports 80 and 443 of all returned IP addresses of all configured upstreams. AdGuard then return a manipulated DNS record, that only contains the fastest IP address.
- else (i.e. the upstreams return a different record type) AdGuard enters the normal “load-balancing“ mode. (see https://github.com/AdguardTeam/dnsproxy/blob/a87a3dfd6b737144a16ef92d130319d12184f129/proxy/exchange.go#L28 )

**Suggested behavior:**
If the upstreams return a different record type than A or AAAA, then AdGuard enters the normal “Parallel requests“ mode, i.e. change line 28 to “return upstream.ExchangeParallel(ups, req)“ (like in https://github.com/AdguardTeam/dnsproxy/blob/a87a3dfd6b737144a16ef92d130319d12184f129/proxy/exchange.go#L22 ).

**Rationale:**
As a user of “Fastest IP address“ I have to accept that generally all upstreams are queried in order to get the best overall system performance. In the case of A/AAAA records that is the fastest content server (not the fastest DNS answer). In case of other record types, that would be the fastest DNS answer, in my opinion.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.