AdguardTeam / AdguardTeam/Scriptlets

Improve 'abort-current-inline-script' — do not block scripts injected by other extensions

Aperta
#506 0 commenti 0 reazioni 1 assegnatario Rivendicata da @maximtop Vedi su GitHub
enhancement Priority: P4
Lingua principale
JavaScript
Stelle
195
Fork
33
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In the default AgGuard filters, there is a rule like `...#%#//scriptlet('abort-current-inline-script', 'globalThis', 'break;case')` (from [here](https://github.com/AdguardTeam/AdguardFilters/blob/6a85024f295ab75ff901d28a479314a45df97cbb/BaseFilter/sections/general_extensions.txt#L252)). This prevents the TamperMonkey extension to load user scripts on the target sites because the script that extension injects uses the `globalThis` property (which raises an error as soon as it is accessed). This rule is used on many sites. Disabling AdGuard for these sites fixes the problem for TM.

Scripts injected by other browser extensions should not be blocked, as they are safe by definition (because the user installed the extensions). Maybe find a way to detect if the script accessing the property to be blocked has been injected by another extension, before deciding to raise an error?

Related TM issue is [here](https://github.com/Tampermonkey/tampermonkey/issues/2323#issuecomment-2959981133).

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.