AdguardTeam / AdguardTeam/Scriptlets

Improve 'abort-current-inline-script' — do not block scripts injected by other extensions

Ouverte
#506 0 commentaires 0 réactions 1 personne assignée Réclamée par @maximtop Voir sur GitHub
enhancement Priority: P4
Langage dominant
JavaScript
Étoiles
195
Forks
33
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

In the default AgGuard filters, there is a rule like `...#%#//scriptlet('abort-current-inline-script', 'globalThis', 'break;case')` (from [here](https://github.com/AdguardTeam/AdguardFilters/blob/6a85024f295ab75ff901d28a479314a45df97cbb/BaseFilter/sections/general_extensions.txt#L252)). This prevents the TamperMonkey extension to load user scripts on the target sites because the script that extension injects uses the `globalThis` property (which raises an error as soon as it is accessed). This rule is used on many sites. Disabling AdGuard for these sites fixes the problem for TM.

Scripts injected by other browser extensions should not be blocked, as they are safe by definition (because the user installed the extensions). Maybe find a way to detect if the script accessing the property to be blocked has been injected by another extension, before deciding to raise an error?

Related TM issue is [here](https://github.com/Tampermonkey/tampermonkey/issues/2323#issuecomment-2959981133).

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.