AdguardTeam / AdguardTeam/FiltersCompiler

2 incorrect errors in the compilation process

未关闭
#149 3 条评论 3 个 reaction 已指派 1 人 已被 @maximtop 认领 在 GitHub 查看
Priority: P4
主要语言
JavaScript
星标
64
派生
11
PR 合并指标
30 天内没有已合并 PR

描述

When looking into https://raw.githubusercontent.com/AdguardTeam/FiltersRegistry/master/filters/ThirdParty/filter_250_DandelionSproutAnnoyances/diff.txt, I've worked out (or at least looked into) various excluded entries, but there are 2 excluded entries that I feel should've been allowed by the compiler, but which aren't:

1) Regarding `Error: "Unknown pseudo class: p:-moz-only-whitespace" in the rule: "##p:-moz-only-whitespace"`, Mozilla has supported `:-moz-only-whitespace` for 20 years now, so I at least presume that the Firefox team didn't intend it to be treated as merely a pseudo class. I therefore feel that AdGuard should treat it as a normal class.

2) Regarding `Error: "Unknown modifier: }-\w{10" in the rule: "$removeparam=/^kk=\w{6,}-\w{10,}-\w{5,}$/"`, I can only presume there's a glitch somewhere in the compiler that makes it think that `}-\w{10` was to be looked at as if it was a modifier.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。