AdguardTeam / AdguardTeam/FiltersCompiler

2 incorrect errors in the compilation process

Open
#149 3 comments 3 reactions 1 assignee Claimed by @maximtop View on GitHub
Priority: P4
Dominant language
JavaScript
Stars
64
Forks
11
PR merge metrics
No merged PRs in 30d

Description

When looking into https://raw.githubusercontent.com/AdguardTeam/FiltersRegistry/master/filters/ThirdParty/filter_250_DandelionSproutAnnoyances/diff.txt, I've worked out (or at least looked into) various excluded entries, but there are 2 excluded entries that I feel should've been allowed by the compiler, but which aren't:

1) Regarding `Error: "Unknown pseudo class: p:-moz-only-whitespace" in the rule: "##p:-moz-only-whitespace"`, Mozilla has supported `:-moz-only-whitespace` for 20 years now, so I at least presume that the Firefox team didn't intend it to be treated as merely a pseudo class. I therefore feel that AdGuard should treat it as a normal class.

2) Regarding `Error: "Unknown modifier: }-\w{10" in the rule: "$removeparam=/^kk=\w{6,}-\w{10,}-\w{5,}$/"`, I can only presume there's a glitch somewhere in the compiler that makes it think that `}-\w{10` was to be looked at as if it was a modifier.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.