AdguardTeam / AdguardTeam/AdguardForAndroid

Improve surface and system bar color

未关闭
#5,185 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Feature request Priority: P4 TechAudit Voting
主要语言
没有语言数据
星标
1.9k
派生
121
PR 合并指标
30 天内没有已合并 PR

描述

Current surface color (pop-up dialog, card, bottom navigation, etc.) looks bad and quite inconsistent together with the background color.

1. Pop-up dialog color with dark material theme is hardly distinguishable with the background color.
![Screenshot_2024-01-24-12-35-19-043_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/90db95c8-5e93-4bcf-bac4-9524b8ced3b6)
\
For both white and white material theme it could be improved later with a new surface color. I was thinking to use the same color as white themed system navigation bar color (#F3F3F3). But we have to consider whether the color is suitable or not. I'm afraid people start to think the dialog is disabled.
![Screenshot_2024-01-24-13-04-06-750_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/d8f0e7a0-caa6-4b39-afd4-1bfe8656a5ac)

2. Card surface color on the homepage for both dark and dark material theme is good and colorful.
![Screenshot_2024-01-24-12-51-52-961_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/23c4d7d7-9c81-4197-96f6-04d3c2c572ca)
![Screenshot_2024-01-24-12-52-10-916_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/019328e4-4ce5-40ab-a510-3637a96eb3cf)
\
Not so much for white and white material theme, its bland. For white material theme, we could use the same yellow color as the dark material theme. For white theme, it could be improved later considering the issue I have talked before.
![Screenshot_2024-01-24-13-11-32-883_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/4dcd06e7-a07e-42ad-9c4a-e8eb9163fda0)
![Screenshot_2024-01-24-12-51-36-486_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/fdc93b8e-1428-4be8-82e0-46859002a803)

\
Now for system status bar, I believe it should have use the same color as toolbar or background if there's none. System navigation bar — classic Android three menu buttons — use the same color as bottom navigation bar or background if there's none. Bottom navigation bar — AdGuard navigation — should have use a different color than background. At least thats how most Android apps are implemented. Few example are Play Store, Gmail, WhatsApp, anything.

1. This system bar color on dark theme is good. It blends with their surrounding — background color.
![Screenshot_2024-01-24-12-55-54-539_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/20720c87-0c7c-469b-881e-87f3aef8f75c)
\
However for white and dark theme...
![Screenshot_2024-01-24-12-55-23-726_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/4275762e-4202-431f-ae6b-d6a5f6d8d85b)
![Screenshot_2024-01-24-12-55-42-116_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/fd79b1cc-08da-4ff2-affd-f21ff0bab7fd)

2. Both bottom and system navigation bar on dark theme is good. It has a color difference from the background, whilst having the same color for both navigation.
![Screenshot_2024-01-24-12-41-37-439_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/a2d3b148-4dcc-49ce-8e8c-a7afcdfa1fc8)
\
However on dark material theme, all the color are same.
![Screenshot_2024-01-24-12-58-06-580_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/75e9f3c8-531e-4278-b8d4-f8c225fd0a07)
\
On white theme, it's quite inconsistent. I guess it safe to use the same color for bottom navigation bar color as the system navigation bar.
![Screenshot_2024-01-24-12-41-51-437_com adguard android-edit](https://github.com/AdguardTeam/AdguardForAndroid/assets/78811448/e5312a50-564e-4a4b-898b-3d535cddb810)

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。