AdguardTeam / AdguardTeam/AdguardForAndroid
Improve surface and system bar color
- Ngôn ngữ chính
- Không có dữ liệu ngôn ngữ
- Star
- 1.9k
- Fork
- 121
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
Current surface color (pop-up dialog, card, bottom navigation, etc.) looks bad and quite inconsistent together with the background color.
1. Pop-up dialog color with dark material theme is hardly distinguishable with the background color.

\
For both white and white material theme it could be improved later with a new surface color. I was thinking to use the same color as white themed system navigation bar color (#F3F3F3). But we have to consider whether the color is suitable or not. I'm afraid people start to think the dialog is disabled.

2. Card surface color on the homepage for both dark and dark material theme is good and colorful.


\
Not so much for white and white material theme, its bland. For white material theme, we could use the same yellow color as the dark material theme. For white theme, it could be improved later considering the issue I have talked before.


\
Now for system status bar, I believe it should have use the same color as toolbar or background if there's none. System navigation bar — classic Android three menu buttons — use the same color as bottom navigation bar or background if there's none. Bottom navigation bar — AdGuard navigation — should have use a different color than background. At least thats how most Android apps are implemented. Few example are Play Store, Gmail, WhatsApp, anything.
1. This system bar color on dark theme is good. It blends with their surrounding — background color.

\
However for white and dark theme...


2. Both bottom and system navigation bar on dark theme is good. It has a color difference from the background, whilst having the same color for both navigation.

\
However on dark material theme, all the color are same.

\
On white theme, it's quite inconsistent. I guess it safe to use the same color for bottom navigation bar color as the system navigation bar.

Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Đánh giá
Issue này chưa được đánh giá.