AdguardTeam / AdguardTeam/AdGuardHome

Improve HTTP responses when the server is panicking

Aperta
#3,740 0 commenti 1 reazione 1 assegnatario Rivendicata da @EugeneOne1 Vedi su GitHub
enhancement P3: Medium
Lingua principale
TypeScript
Stelle
36.9k
Fork
2.5k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Currently, there are cases where AdGuard Home's internals encounter a runtime panic, which results in the frontend receiving no responses. AGH doesn't crash itself, since the default HTTP server has its own panic handling, but that's still rather poor UX.

What we need is a simple HTTP middleware that:

1. Recovers the panic.

2. Writes a `500` response with an appropriate content type (typically, a JSON object) that contains the panic's message.

3. Writes a backtrace, preferably on the `error` level as opposed to the current `debug`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.