AdguardTeam / AdguardTeam/AdGuardHome

Improve HTTP responses when the server is panicking

Abierto
#3,740 0 comentarios 1 reacción 1 asignado Reclamado por @EugeneOne1 Ver en GitHub
enhancement P3: Medium
Lenguaje dominante
TypeScript
Estrellas
36.9k
Forks
2.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently, there are cases where AdGuard Home's internals encounter a runtime panic, which results in the frontend receiving no responses. AGH doesn't crash itself, since the default HTTP server has its own panic handling, but that's still rather poor UX.

What we need is a simple HTTP middleware that:

1. Recovers the panic.

2. Writes a `500` response with an appropriate content type (typically, a JSON object) that contains the panic's message.

3. Writes a backtrace, preferably on the `error` level as opposed to the current `debug`.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.