AdguardTeam / AdguardTeam/AdGuardHome

Figure out the source of the occasional fsnotify test failures

Ouverte
#3,432 0 commentaires 0 réactions 1 personne assignée Réclamée par @EugeneOne1 Voir sur GitHub
enhancement P4: Low
Langage dominant
TypeScript
Étoiles
36.9k
Forks
2.5k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Every once in a while, there are test failures in the `aghnet` package, most of which are linked in one way or another to the `github.com/fsnotify/fsnotify` module. These failures are annoying, and we should investigate, why they happen and how can we prevent them. Perhaps there is a kind of filesystem race condition there?

An example of such failure:

```none
=== RUN TestEtcHostsContainerFSNotify
=== RUN TestEtcHostsContainerFSNotify/unknown_host
=== RUN TestEtcHostsContainerFSNotify/notified
etchostscontainer_test.go:126:
Error Trace: etchostscontainer_test.go:126
Error: Expected value not to be nil.
Test: TestEtcHostsContainerFSNotify/notified
etchostscontainer_test.go:127:
Error Trace: etchostscontainer_test.go:127
Error: "[]" should have 1 item(s), but has 0
Test: TestEtcHostsContainerFSNotify/notified
--- FAIL: TestEtcHostsContainerFSNotify (0.19s)
--- PASS: TestEtcHostsContainerFSNotify/unknown_host (0.00s)
--- FAIL: TestEtcHostsContainerFSNotify/notified (0.00s)
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.