AdguardTeam / AdguardTeam/AdGuardHome

Figure out the source of the occasional fsnotify test failures

Offen
#3,432 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @EugeneOne1 Auf GitHub ansehen
enhancement P4: Low
Vorherrschende Sprache
TypeScript
Sterne
36.9k
Forks
2.5k
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Every once in a while, there are test failures in the `aghnet` package, most of which are linked in one way or another to the `github.com/fsnotify/fsnotify` module. These failures are annoying, and we should investigate, why they happen and how can we prevent them. Perhaps there is a kind of filesystem race condition there?

An example of such failure:

```none
=== RUN TestEtcHostsContainerFSNotify
=== RUN TestEtcHostsContainerFSNotify/unknown_host
=== RUN TestEtcHostsContainerFSNotify/notified
etchostscontainer_test.go:126:
Error Trace: etchostscontainer_test.go:126
Error: Expected value not to be nil.
Test: TestEtcHostsContainerFSNotify/notified
etchostscontainer_test.go:127:
Error Trace: etchostscontainer_test.go:127
Error: "[]" should have 1 item(s), but has 0
Test: TestEtcHostsContainerFSNotify/notified
--- FAIL: TestEtcHostsContainerFSNotify (0.19s)
--- PASS: TestEtcHostsContainerFSNotify/unknown_host (0.00s)
--- FAIL: TestEtcHostsContainerFSNotify/notified (0.00s)
```

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.