AdamNiederer / AdamNiederer/faster

Arbitrary collect support

Aperta
#35 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
1.6k
Fork
52
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I noticed that some methods return `Vec`s. In particular, it's `stride` and `scalar_collect`. I was wondering if it made sense to expose generic version that could use arbitrary `FromIterator` type. My motivation for this is:

* It would allow for use in nostd environment, for example with arrayvec.
* It would allow storing the results on the stack, again with arrayvec or with smallvec (to avoid allocations for the small cases while falling back on it in the big ones when the allocation cost is amortized).

The original methods could still be preserved, as wrappers with `Vec` implementation. Does it make sense? Should I send a pull request for that?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.