AdamNiederer / AdamNiederer/faster

Arbitrary collect support

Abierto
#35 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
1.6k
Forks
52
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I noticed that some methods return `Vec`s. In particular, it's `stride` and `scalar_collect`. I was wondering if it made sense to expose generic version that could use arbitrary `FromIterator` type. My motivation for this is:

* It would allow for use in nostd environment, for example with arrayvec.
* It would allow storing the results on the stack, again with arrayvec or with smallvec (to avoid allocations for the small cases while falling back on it in the big ones when the allocation cost is amortized).

The original methods could still be preserved, as wrappers with `Vec` implementation. Does it make sense? Should I send a pull request for that?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.