ActivityWatch / ActivityWatch/aw-qt

Server port lookup is Rust-first while the module probe is implementation-specific

未关闭
#129 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
33
派生
62
平均合并
18 小时 54 分钟
30 天内合并 PR
5

描述

Split out of the Greptile review on #128 (P1), where it was flagged but is pre-existing on `master` and not profile-specific.

`aw_qt/config.py:_read_server_port()` tries the aw-server-rust config first and falls back to the aw-server (Python) config, then to a default port. `aw_qt/manager.py:Module._get_server_port()` instead reads the config belonging to the module it is probing. When both configs exist and disagree — or when the Python server is the one in `autostart_modules` but only a Rust config sets a port — the tray's dashboard/API links can target a different endpoint than the server the manager actually starts and probes.

Likely fix: resolve the port from whichever server implementation is in `autostart_modules`, rather than a fixed Rust-first order. That changes port resolution for existing installs, so it wants its own PR and its own thought about back-compat.

Noted while adding `--profile` (#128): a custom profile with no port configured falls back to 5600, so a wrong-endpoint link points at the production instance. #128 logs a warning for that case but does not change the lookup order.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。