ActivityWatch / ActivityWatch/aw-qt

Server port lookup is Rust-first while the module probe is implementation-specific

Aperta
#129 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
33
Fork
62
Merge medio
18h 54m
PR unite (30g)
5

Descrizione

Split out of the Greptile review on #128 (P1), where it was flagged but is pre-existing on `master` and not profile-specific.

`aw_qt/config.py:_read_server_port()` tries the aw-server-rust config first and falls back to the aw-server (Python) config, then to a default port. `aw_qt/manager.py:Module._get_server_port()` instead reads the config belonging to the module it is probing. When both configs exist and disagree — or when the Python server is the one in `autostart_modules` but only a Rust config sets a port — the tray's dashboard/API links can target a different endpoint than the server the manager actually starts and probes.

Likely fix: resolve the port from whichever server implementation is in `autostart_modules`, rather than a fixed Rust-first order. That changes port resolution for existing installs, so it wants its own PR and its own thought about back-compat.

Noted while adding `--profile` (#128): a custom profile with no port configured falls back to 5600, so a wrong-endpoint link points at the production instance. #128 logs a warning for that case but does not change the lookup order.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.