AcademySoftwareFoundation / AcademySoftwareFoundation/OpenShadingLanguage

clang10 and pkgconfig issues with v1.11.4.1-dev

Aperta
#1,155 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
2.3k
Fork
414
Merge medio
3g 1h
PR unite (30g)
10

Descrizione

With gcc9 and clang10 libclang-cpp has been introduced resulting in liboslexec and liboslcomp failing at link time, sorry I didn't have time to make a patch, I work around this in the spec file with:
%if 0%{?llvm_version} >= 10
"#" Add missing -lclang-cpp to linker scripts for liboslcomp and liboslexec
sed -i 's/\-ldl /\-ldl \-lclang-cpp /' src/liboslexec/CMakeFiles/oslexec.dir/link.txt
sed -i 's/\-ldl /\-ldl \-lclang-cpp /' src/liboslcomp/CMakeFiles/oslcomp.dir/link.txt
%endif
I'm not 100% sure when libclang was split but it wasn't in clang7 but it is in clang10
The other issue I made a patch for is:
CMakeLists.txt fails to provide Version:
@PACKAGE_VERSION_MAJOR@.@PACKAGE_VERSION_MINOR@.@PACKAGE_VERSION_PATCH@ for pc files resulting in a Version: field of .. I wouldn't have picked this up but rpmbuild chokes on the .. Version field when it creates the pkgconfig() provides.
[osl-pkgconfig-versions.patch.txt](https://github.com/imageworks/OpenShadingLanguage/files/4508954/osl-pkgconfig-versions.patch.txt)
See: https://build.opensuse.org/package/show/home:plater:blender/OpenShadingLanguage

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Riprodurre la build clang10/gcc9 ed esaminare CMakeLists.txt, oltre a src/liboslexec/CMakeFiles/oslexec.dir/link.txt e src/liboslcomp/CMakeFiles/oslcomp.dir/link.txt. Esaminare il file allegato osl-pkgconfig-versions.patch.txt e verificare che il linking abbia esito positivo e che i file pkg-config generati contengano un campo Version valido accettabile da rpmbuild.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
cmake, cpp
Ambito
build-system, devops
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.