AcademySoftwareFoundation / AcademySoftwareFoundation/OpenShadingLanguage
clang10 and pkgconfig issues with v1.11.4.1-dev
- Lenguaje dominante
- C++
- Estrellas
- 2.3k
- Forks
- 415
- Merge medio
- 3 d 1 h
- PR fusionados (30 d)
- 10
Descripción
With gcc9 and clang10 libclang-cpp has been introduced resulting in liboslexec and liboslcomp failing at link time, sorry I didn't have time to make a patch, I work around this in the spec file with:
%if 0%{?llvm_version} >= 10
"#" Add missing -lclang-cpp to linker scripts for liboslcomp and liboslexec
sed -i 's/\-ldl /\-ldl \-lclang-cpp /' src/liboslexec/CMakeFiles/oslexec.dir/link.txt
sed -i 's/\-ldl /\-ldl \-lclang-cpp /' src/liboslcomp/CMakeFiles/oslcomp.dir/link.txt
%endif
I'm not 100% sure when libclang was split but it wasn't in clang7 but it is in clang10
The other issue I made a patch for is:
CMakeLists.txt fails to provide Version:
@PACKAGE_VERSION_MAJOR@.@PACKAGE_VERSION_MINOR@.@PACKAGE_VERSION_PATCH@ for pc files resulting in a Version: field of .. I wouldn't have picked this up but rpmbuild chokes on the .. Version field when it creates the pkgconfig() provides.
[osl-pkgconfig-versions.patch.txt](https://github.com/imageworks/OpenShadingLanguage/files/4508954/osl-pkgconfig-versions.patch.txt)
See: https://build.opensuse.org/package/show/home:plater:blender/OpenShadingLanguage
Guía de contribución
Línea de trabajo
Reproducir la compilación clang10/gcc9 e inspeccionar CMakeLists.txt, además de src/liboslexec/CMakeFiles/oslexec.dir/link.txt y src/liboslcomp/CMakeFiles/oslcomp.dir/link.txt. Revisar el archivo adjunto osl-pkgconfig-versions.patch.txt y verificar que la vinculación se complete correctamente y que los archivos pkg-config generados contengan un campo Version válido aceptable para rpmbuild.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- cmake, cpp
- Área
- build-system, devops
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 42/100