AbsaOSS / AbsaOSS/enceladus

Use slf4j instead of log4j everywhere in the project

未关闭
#802 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
feature priority: low refactoring
主要语言
Scala
星标
33
派生
16
PR 合并指标
30 天内没有已合并 PR

描述

## Background
Reported by @GeorgiChochov.

Slf4j is an abstraction layer for logging and exact implementation to use is determined at deployment time. Currently, Spark is our root project dependency and it uses log4j implementation. Rather than depending on a concrete logging backend, it is a good practice to make modules depend on interfaces provided by slf4j. In our case, the logging backend is provided by Spark. So another reason to use slf4j.

## Feature
Use slf4j instead of log4j everywhere in the project. Especially everywhere we have Spark dependency.

## Proposed Solution [Optional]
Basically,

replace

```scala
import org.apache.log4j.LogManager

private val log = LogManager.getLogger(this.getClass)
```

with

```scala
import org.slf4j.{Logger, LoggerFactory}

private val log: Logger = LoggerFactory.getLogger(this.getClass)
```

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。